UPDATE 2: Thanks to @fuurthur, I am now taking this from “Help Needed” to “Work In Progress” status. All issues have been fixed. This version is 0.9.7 and won’t be a final, ready-to-go version 1.0 until I can add a couple of “icing on the cake” features (see below.)
UPDATE: I uploaded a new version (0.9.4) which fixes the Decay issue I was having. Thanks to @iquestionshard for the fix!
———————————————————————-
A Karplus-Strong patch to simulate a Strumming Guitar. Features I’m still wanting to add before a version 1.0 release:
1. The ability to Transpose the Strummer with the keyboard when the Strummer is engaged.
2. Possibly add an additional Aux page for effects; such as an addition of a swirling stereo sound like in the Genny 1 patch. Or at least a controllable Reverb.
Just for further clarification, when I had the Aux button connected to the strummer the normal way (with an [r notes] to trigger the initial strum) it played the strummer at twice the speed and caused a loud noise sound when you turned off the strummer with the Aux button. The noise sound sustains until you press a keys and returns upon releasing the key. By instead, adding the [bang] the way I did between the aux/sel and the strummer, this fixed the speed issue and the noise issue, but now the strummer stays on permanently even when you turn Aux off.
This sounds sick. I hope you get the help you need with this because it’ll make an excellent patch when it’s perfected. Thank you for making this! I love how it sounds almost like a harpsichord at fast tempos
Ok so, after two weeks of being up on this site, I see lots of downloads, but no fixes? Is anybody actually helping to work on this in the spirit of the Open Source community, or is everyone just enjoying it how it is? Back in my Linux days (late 1990s) people use to fix patches on day one!
When this patch is running properly, it will be a masterpiece.
I’m new to PD, and apart fron the “infinite monkey theorem”, it’s doubtful I can offer any technical advice. I downloaded the patch for the educational value, and continue to learn as the community pitches in.
Thank you for sharing this brilliant work in progress, and allowing me, and others like myself to watch and learn.
One compromise I just tried is, I got rid of the [sel 1] altogether (since the [pd latch] also had it’s own [sel] object; I figured they were conflicting) and patched the [r fs] and [r aux] directly into the [pd latch] left input, so now you can “Hold” the Aux button to get the Strummer to play and then let go of the Aux to get it to stop. But this doesn’t update the screen to reflect that the Aux is being held On.
Amazing sounds! I think I may have solved the aux button issue. I included two small objects in the folder, tglsel and tglsel inv They are helpful when you need a tgl object to remain on (or off) as opposed to the bang from a normal sel object. I also added an inlet to reset the strum count. I think this patch would be more useful if the chords were determined by the keyboard as opposed to preset as they are now. Hope this helps with the project and congrats on an innovative contribution to the organelle community!
Oh, I also changed the decay values, It seemed to have a very small useable area, most of the knob range was super short. I left your argument beside my clumsy math. ;)
Attachment My-Guitar-Strummer-Fuurthur-revision.zip
@fuurthur thank you so much for the contribution! I like the Decay fix that you did! The only thing regarding the Aux button is, it still doesn’t actually latch. When I tested your version, I still had to hold the Aux button to get it to strum (the same way it worked when I simply deleted the [sel 1] object and tied the [aux] object directly to the strummer.)
Also it defaults to the strummer being On when the patch is first loaded, I’d rather that not happen (I want people to be able to play the keyboard first, then turn the Strummer On and have it latch so they can use both hands to tweak the Width/Decay/Cutoff settings.) And the Screen still doesn’t reflect what’s happening with the Aux button.
It seems we still got a bit to go for this one Aux button/Strummer fix, but once we can get past that, some of the ideas I had for extending this patch (sort of the “icing on the cake” stuff) was to be able to put your own notes in for the chord, or to at least be able to transpose the strummer chord with the keyboard.
Thanks again for your contribution, and for the kind words on my meager efforts… if there is any further fixes you can muster, it would be greatly appreciated!
That was my laziness before. I wasn’t sure if you wanted to have the aux switch latch on not. should be good. Oled should update and led light up when strum is engaged. Changed the tone parameters to more controllable values.
P.S. I’ve totally snagged that pluck sound and have already started injecting it into other patches! Very nice.
Attachment My-Guitar-Strummer-2nd-revision.zip
@fuurther you are awesome! Thanks! I’m uploading the new version and changing the status to “Work In Progress” and changing the version number to 0.9.7 (it’s not going to be a 1.0 until I can add a couple of more things I wanted to do, like transposing the strummer, etc.)
The only thing I changed on this version is, I reattached the screen for the Decay, and put back the original Cutoff and Width parameters because it is those wild extremes that are part of the charm of the Karplus-Strong algorithm (the ability to turn Cutoff all the way up to 8000 and then the Width down to 0% and get those long, smeared, sustaining sounds.) I also added your username as well as iquestionshard from the C&G forum to the credits.
Thanks again for your help!
thank you for your patch! love the demo
Thank you @Xuefeng Ji for checking it out!